Thread: Patch to fix a small problem with `make distclean'

Started: 2008-10-01 22:22:59
Last activity: 2008-10-02 02:20:38
Topics: SAC Developers
Hi all,

Right now, in a source tree that has been configured with libedit, if
we use `make clean', all the generated files and directories under
libedit/ would be cleaned. However, if we use `make distclean', which
is supposed to be a superset of `make clean', not all the generated
files/dirs are cleaned properly. Like this:

$ cd libedit
$ make distclean
$ ll
total 16K
drwxr-xr-x 3 icrazy icrazy 4.0K Sep 30 02:15 include
drwxr-xr-x 2 icrazy icrazy 4.0K Sep 30 02:15 lib
drwxr-xr-x 5 icrazy icrazy 4.0K Sep 30 02:15 libedit-2.6.9
drwxr-xr-x 4 icrazy icrazy 4.0K Sep 30 02:15 man

Attached is a patch that utilizes [1] to fix this behavior, as well as
some corresponding documentation.

[1] Extending Automake Rules
http://sources.redhat.com/automake/automake.html#Extending


Best regards,

--
Kuang He
Department of Physics
University of Connecticut
Storrs, CT 06269-3046

Tel: +1.860.486.4919
Web: http://www.phys.uconn.edu/~he/

  • Kuang and others,

    We were aware of the fact that distclean did not truly clean the libedit stuff,
    and the following line is in the Readme.buildsac:

    % make distclean > /dev/null - Removes configuration files as well. Must
    run make clean first.

    I forget if Brian had a reason for not making a fix in the Makefile. We'll look
    at your patch.

    Arthur

    Kuang He wrote:
    Hi all,

    Right now, in a source tree that has been configured with libedit, if
    we use `make clean', all the generated files and directories under
    libedit/ would be cleaned. However, if we use `make distclean', which
    is supposed to be a superset of `make clean', not all the generated
    files/dirs are cleaned properly. Like this:

    $ cd libedit
    $ make distclean
    $ ll
    total 16K
    drwxr-xr-x 3 icrazy icrazy 4.0K Sep 30 02:15 include
    drwxr-xr-x 2 icrazy icrazy 4.0K Sep 30 02:15 lib
    drwxr-xr-x 5 icrazy icrazy 4.0K Sep 30 02:15 libedit-2.6.9
    drwxr-xr-x 4 icrazy icrazy 4.0K Sep 30 02:15 man

    Attached is a patch that utilizes [1] to fix this behavior, as well as
    some corresponding documentation.

    [1] Extending Automake Rules
    http://sources.redhat.com/automake/automake.html#Extending


    Best regards,



    ------------------------------------------------------------------------

    _______________________________________________
    sac-dev mailing list
    sac-dev<at>iris.washington.edu
    http://www.iris.washington.edu/mailman/listinfo/sac-dev


Page built 22:03:31 | v.090361a2