Thread: src/makefile patch

Started: 2005-12-13 02:51:42
Last activity: 2005-12-13 03:12:31
Topics: SAC Developers
George Helffrich
2005-12-13 02:51:42
Brian points out a flaw in the previous committed patch that I believe
that this one fixes. It succeeds in all the build examples Brian gives
below. Please let me know if it fails in any new, obscure way, or is a
satisfactory fix. It works (in bash) with:

make
make OSTYPE=darwin
OSTYPE=darwin make
export OSTYPE=darwin; make

Index: src/makefile
===================================================================
RCS file: /export/home/cvs/repository/SAC/src/makefile,v
retrieving revision 1.2
diff -u -r1.2 makefile
--- src/makefile 1 Dec 2005 18:17:57 -0000 1.2
+++ src/makefile 3 Dec 2005 17:53:03 -0000
@@ -26,7 +26,7 @@
###########################################################

OSTYPES_SUPPORTED=solaris linux darwin darwin6.0
-OSTYPE=`echo $$OSTYPE`
+OSTYPE := $(shell echo $$OSTYPE)
export SACCFLAGS
export DEBUG


On Friday, December 2, 2005, at 06:46 PM, savage13 at dtm.ciw.edu wrote:

> George,
>
>I tried to compile the source following the addition of your patch
>% export OSTYPE=darwin
>% make
>This fails due to the line >OSTYPE=`echo $$OSTYPE`
>and the checking for valid operating systems in the ostype: rule
>and (if test x$XOSTYPE = x$$z)
>
>It also does not work like
>% env OSTYPE=darwin make
>
>
>Although it does work using
>% make OSTYPE=darwin
>
>Is there a way we could fix this such that is works in the darwin6
>system
>and satisfies these different cases.
>
>Cheers,
>Brian
>
>
>
>
>
>
>
>
> 2005/12/01 George Helffrich http://www1.gly.bris.ac.uk~george/gh.html
>
> * Tweak makefile so MacOS 10.2.x builds work
> (src/makefile)
>
> * Update Readme info to mention 10.2.x builds work
> (Readme.buildsac)
  • Brian Savage
    2005-12-12 22:04:07
    George,

    I will test these today and get back to you later.

    I have also been working on moving the build system to
    a configure system. This will do away with the problems we have been
    having trying to compile on untested platforms and hopefully reduce the
    build times you have mentioned previously.

    Cheers,
    Brian

    George Helffrich wrote:
    Brian points out a flaw in the previous committed patch that I believe
    that this one fixes. It succeeds in all the build examples Brian gives
    below. Please let me know if it fails in any new, obscure way, or is a
    satisfactory fix. It works (in bash) with:

    make
    make OSTYPE=darwin
    OSTYPE=darwin make
    export OSTYPE=darwin; make

    Index: src/makefile
    ===================================================================
    RCS file: /export/home/cvs/repository/SAC/src/makefile,v
    retrieving revision 1.2
    diff -u -r1.2 makefile
    --- src/makefile 1 Dec 2005 18:17:57 -0000 1.2
    +++ src/makefile 3 Dec 2005 17:53:03 -0000
    @@ -26,7 +26,7 @@
    ###########################################################

    OSTYPES_SUPPORTED=solaris linux darwin darwin6.0
    -OSTYPE=`echo $$OSTYPE`
    +OSTYPE := $(shell echo $$OSTYPE)
    export SACCFLAGS
    export DEBUG


    • Brian Savage
      2005-12-13 03:12:31
      George,

      I tested on all three platfoms and all build fine.
      Go ahead a submit your patch, unless someone objects.

      Cheers,
      Brian


      Brian Savage wrote:
      George,

      I will test these today and get back to you later.

      I have also been working on moving the build system to
      a configure system. This will do away with the problems we have been
      having trying to compile on untested platforms and hopefully reduce the
      build times you have mentioned previously.

      Cheers,
      Brian

      George Helffrich wrote:

      Brian points out a flaw in the previous committed patch that I believe
      that this one fixes. It succeeds in all the build examples Brian gives
      below. Please let me know if it fails in any new, obscure way, or is a
      satisfactory fix. It works (in bash) with:

      make
      make OSTYPE=darwin
      OSTYPE=darwin make
      export OSTYPE=darwin; make

      Index: src/makefile
      ===================================================================
      RCS file: /export/home/cvs/repository/SAC/src/makefile,v
      retrieving revision 1.2
      diff -u -r1.2 makefile
      --- src/makefile 1 Dec 2005 18:17:57 -0000 1.2
      +++ src/makefile 3 Dec 2005 17:53:03 -0000
      @@ -26,7 +26,7 @@
      ###########################################################

      OSTYPES_SUPPORTED=solaris linux darwin darwin6.0
      -OSTYPE=`echo $$OSTYPE`
      +OSTYPE := $(shell echo $$OSTYPE)
      export SACCFLAGS
      export DEBUG

      _______________________________________________
      sac-dev mailing list
      sac-dev<at>iris.washington.edu
      http://www.iris.washington.edu/mailman/listinfo/sac-dev


18:59:38 v.22510d55